.github/workflows: naive PR format checker #32480
Merged
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Aug 22, 2025
gballet
changed the title
gballet
changed the title
gballet
commented
Aug 22, 2025
gballet
commented
Aug 22, 2025
gballet
commented
Aug 22, 2025
gballet
commented
Aug 22, 2025
gballet
commented
Aug 22, 2025
gballet
force-pushed
the
pr-format-checker
branch
from
e36a082 to
ffcc8e8
Compare
|
I like the idea, but the workflow is only triggered on a commit, so if we only add the milestone or rename the PR, it will not be retriggered. I like the naming one, since it will encourage/force contributors to adhere to our naming guidelines |
|
it is run on edits too, you can see in the history that it ran after I changed the name. The milestone indeed doesn't seem to run if I remove it. I'll double-check, because it should. |
|
indeed it doesn't, at least not right away. The name change does work though, and the milestone isn't such a big deal after all. I'll comment it out for now. |
|
This is a really good idea. |
|
looks good |
gballet
commented
Aug 25, 2025
jwasinger
approved these changes
Aug 25, 2025
|
Btw this fails for root-level files e.g. README.md, AUTHORS etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full disclosure: this has been generated by AI. The goal is to have a quick check that the PR format is correct, before we merge it. This is to avoid the periodical case when someone forgets to add a milestone or check the title matches our preferred format.